Make EcoVec::extend_from_trusted public
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 88.04% 88.09% +0.04%
==========================================
Files 3 3
Lines 1096 1100 +4
==========================================
+ Hits 965 969 +4
Misses 131 131 ☔ View full report in Codecov by Sentry. |
|
Unfortunate that |
kaikalii
force-pushed
the
main
branch
2 times, most recently
from
08e32fa
to
0b0a84d
Compare
Add the bound `I::IntoIter: ExactSizeIterator` to try to prevent unsafe usage. The `count` parameter is removed in favor of `ExactSizeIterator::len`.
|
I think that makes more sense. Updated. |
|
Thanks! Do you want a release? |
|
That would be great. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the bound
I::IntoIter: ExactSizeIteratorto try to prevent unsafe usage.I need this so I can do no-
Cloneextension without the overhead of the safeExtend::extendimplementation referenced in #38.